feat: update partition duration of memtable using compaction window #5197
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5197 +/- ##
==========================================
- Coverage 84.14% 83.86% -0.28%
==========================================
Files 1177 1184 +7
Lines 218960 220074 +1114
==========================================
+ Hits 184234 184556 +322
- Misses 34726 35518 +792 |
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/mito2/src/engine/compaction_test.rs: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/mito2/src/memtable/time_partition.rs:570
- [nitpick] The function name
test_write_multi_partsis not very descriptive. Consider renaming it totest_write_multiple_partitions.
fn test_write_multi_parts() {
src/mito2/src/memtable/version.rs:108
- Ensure that the
time_windowparameter is correctly propagated and used in theforkfunction.
let mutable = Arc::new(self.mutable.fork(metadata, time_window));
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
fixes #5098
What's changed and what's your intention?
This PR tries to create a new mutable memtable with the latest compaction time window. It sets the
part_durationof theTimePartitionswhen a region freezes its memtables.Checklist